Add ROCm packages to PACKAGE_LINKS_ALLOW_LIST - #8445
Merged
Conversation
pytorch#8436 taught update_dependencies.py to mirror the rocm7.14 dependency wheels from repo.amd.com, adding 28 packages under project "torch_rocm". Those packages also need to be in PACKAGE_LINKS_ALLOW_LIST so manage_v2.py copies their index.html down from the parent prefix instead of regenerating it from wheel listings -- the same treatment the nvidia-* and Intel/XPU dependency packages already get. The list is the exact set of PACKAGES_PER_PROJECT entries with project "torch_rocm": rocm, rocm-sdk-core, rocm-sdk-libraries and the 25 rocm-sdk-device-gfx* packages.
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
jithunnair-amd
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the 28 ROCm dependency packages introduced by #8436 to
PACKAGE_LINKS_ALLOW_LISTins3_management/manage_v2.py.#8436 taught
update_dependencies.pyto mirror the rocm7.14 dependency wheelsfrom
repo.amd.com/rocm/whl-multi-arch, adding 28 entries toPACKAGES_PER_PROJECTunder projecttorch_rocm. Packages inPACKAGE_LINKS_ALLOW_LISTget theirindex.htmlcopied down from the parentprefix rather than regenerated from wheel listings — e.g.
whl/nightly/rocm-sdk-core/index.html→whl/nightly/rocm7.14/rocm-sdk-core/index.html— which is what lets a subdirectory index point at externally sourced packages.
The
nvidia-*and Intel/XPU dependency packages are already handled this way;the ROCm ones were missed.
The packages
Rather than transcribe these from the diff by hand, I generated them from the
merged source: every
PACKAGES_PER_PROJECTkey with a config whoseprojectistorch_rocm. So the two lists cannot drift from a typo here.Test plan
Checked by parsing both files with
astafter the change:python -m py_compile s3_management/manage_v2.pypassesblack --checkreports the file unchangedflake8output is byte-identical tomain's (the existing E501/B023 findingsare pre-existing and far below the edited region)
Data-only change; no logic touched.
Note
PACKAGE_ALLOW_LISTdeliberately does not get these entries — it does notcarry the
nvidia-*or Intel dependency packages either, so this matches theestablished pattern for mirrored third-party deps.